[illumos-Developer] [REVIEW] 289 invalid padding when using java pkcs11 provider

Garrett D'Amore garrett at damore.org
Fri Oct 8 11:39:00 PDT 2010


On Fri, 2010-10-08 at 13:35 -0500, Jason King wrote:
> I believe Rich said that the code is (currently) at least never used
> in the kernel (which is probably why that KM_SLEEP never caused a
> compile failure), but yeah, might as well do it right while we're
> working on it.
> 
> Would it be advisable to put the final if (s != NULL) under an
> #if..#endif for any editors as well?:
> 
>     #ifdef _KERNEL
>     if (s != NULL)
>         kmem_free(s, s_size);
>     #else
>     if (s != NULL)
>         free(s);
>     #endif

Don't think so. :-)

	- Garrett
> 
> On Fri, Oct 8, 2010 at 1:11 PM, Gordon Ross <gordon.w.ross at gmail.com> wrote:
> > Oh, and the kmem_alloc needs another arg, I think :)
> > i.e. KM_SLEEP
> >
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer





More information about the Developer mailing list