[illumos-Developer] webrev: add quiesce(9E) support to ixgbe driver
McBofh
james.c.mcpherson at gmail.com
Wed Oct 13 16:25:05 PDT 2010
On 14/10/10 08:52 AM, Mike Riley wrote:
> On 10/13/10 15:06, Joerg Goltermann wrote:
>> Hello,
>>
>> I've uploaded a small diff to cr.illumos.org which add quiesce/
>> fastreboot support to the ixgbe driver.
>>
>> http://cr.illumos.org/view/1nvg3l6p
>>
>> Any comments welcome. Please be gentle, this is my first webrev..
>
> Shouldn't the driver version be bumped (line 33)?
No. Why would we do that? Most SCCS-style %I% went away when ON
moved to use mercurial, and others are removed as files get changed.
> What is the purpose of setting hw in line 676? It is never used in
>the function, so that line and the declaration at line 669 should be removed.
That's a good question!
McB
More information about the Developer
mailing list