[illumos-Developer] Problems in setlocale and codereview

[Joerg Schilling]

"Garrett D'Amore" <garrett at nexenta.com> wrote:

> For a change like the i18n work, where I would up making a non-trivial
> number of changes not to internals, but also to which files I took,
> where they went, and even collapsing them, I think such a set of diffs
> would be difficult to generate automatically.
>
> That said, I'll try to post better diffs against FreeBSD when I import
> in the future.

The problem in our case was that the original code from FreeBSD was not clean 
(as it used secret knowledge about constraints to write loops).

The patch I send is written in a defensive way that make the code immune 
against reordering of tables. When importing code from other sources we need to 
be very careful about changes in order to retain the code quality in Illimos.

Jörg

-- 
 EMail:joerg at schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
       js at cs.tu-berlin.de                (uni)  
       joerg.schilling at fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/private/ ftp://ftp.berlios.de/pub/schily