[illumos-Developer] Problems in setlocale and codereview

[Garrett D'Amore]

For a change like the i18n work, where I would up making a non-trivial
number of changes not to internals, but also to which files I took,
where they went, and even collapsing them, I think such a set of diffs
would be difficult to generate automatically.

That said, I'll try to post better diffs against FreeBSD when I import
in the future.

	- Garrett

On Thu, 2010-09-02 at 10:15 -0400, Albert Lee wrote:
> On Thu, Sep 2, 2010 at 7:35 AM, Joerg Schilling
> <Joerg.Schilling at fokus.fraunhofer.de> wrote:
> 
> > It is obvious that we need a new review tool that creates diffs from e.g. BSD
> > to the current code to be able to check for bugs that have been added while
> > adopting code for Solaris.
> >
> > Jörg
> 
> Absolutely right.
> 
> Quoting Gordon Ross:
>  <gwr>   Oh, I was going to mention:  When we import stuff (i.e. from
> FreeBSD), it's sometimes helpful to do the webrev such that the
> changes from the original are shown.  Just put the old srcs somewhere
> and list them after the new file names in the "active" file you pass
> to webrev...
> 
> Does this mean that webrev can do this?
> 
> -Albert
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer