[illumos-Developer] Problems in setlocale and codereview

[Joerg Schilling]

"Garrett D'Amore" <garrett at damore.org> wrote:

> > AFAIK, I have no permission to put things back to the illumos hg.
>
> Right.  I'll give you the permission to do so, once you and I have a
> chat, and I've verified that your integration is well-formed.  You will
> need to make sure you have your public ssh key in your illumos account
> though, since that's what we use to enable the permission.

The ssh key is correct.



> > 
> > I have some questions:
> > 
> > -	How do I apply my delta to my local repository?
>
> I'm not sure I understand what you mean by this question.  If you've
> already edited the code, you can commit locally using "hg commit".

Looks like a highly probable answer ;-) 
All SCM look different and every software seems to call things different, so I 
just wanted to be sure.

> > -	How is the mail address from what I see with "hg log", e.g.:
> > 
> > 	changeset:   13162:61ea578f8715
> > 	user:        Garrett D'Amore <garrett at nexenta.com>
> > 	date:        Mon Aug 30 23:48:20 2010 -0700
> > 	summary:     7 Need locale databases
> > 
> > 	derived? 
>
> Its taken from ~/.hg/hgrc.  What you should do is
> run /opt/onbld/bin/hgsetup which sets up a template file for you.

I hope that 

hgsetup.sh -f -e joerg at schily.net -c /opt/onbld/lib/python2.4/onbld/hgext/cdm.py

is OK.

> Whichever you prefer.   If your employer owns the copyright, it would be
> best to integrate using an email address @ your employer, but that's
> been you and your employer. :-)

OK, so I selected the private address.


> Let me review the code in more depth.  I've been in meetings all morning
> and haven't had a chance to read the actual code yet.

Do you like to get a new source?

Note that I recommend to always write:

	for (.....) {
	}

even though the curly brackets are not needed. This reduces the probability to 
introduce bugs when enhanging the code.

Jörg

-- 
 EMail:joerg at schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
       js at cs.tu-berlin.de                (uni)  
       joerg.schilling at fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/private/ ftp://ftp.berlios.de/pub/schily