[illumos-Developer] [REVIEW] 248 mdnsd fails to run inside zone due to broken code

[Garrett D'Amore]

Makefile:  remove #ident on line 24

mDNSUNP.c: can we please remove the expanded $Log$ at line 23?  And line
21 while we're at it?   In general it would appear that this code was
imported without any conformance to cstyle or other typical ON
guidelines.  That suggests that there is an upstream that should be
notified of the change?  (If we're not sync'ing with the upstream, then
we should bite the bullet and clean the non-applicable #ifdefs up, and
also fix the style.  We can do that later, if you file a CR to indicate
it.)

	- Garrett


On Sun, 2010-09-26 at 16:51 -0400, Richard Lowe wrote:
> I'd like review for:
> 
>    248 mdnsd fails to run inside zone due to broken code
> 
> webrev: http://richlowe.net/webrevs/il-mdns-zones/
> 
> As the bug says, the check here was completely busted in the face of
> stack instances, but further (and as independently mentioned on
> networking-discuss in response to Alasdair), the only thing this block
> of code did was introduce this bug, SIOCGLIFCONF only returns interfaces
> in the current zone unless lifc_flags includes LIFC_ALLZONES and is
> being done from the GZ.
> 
> I've tested this by enabling mdnsd in both shared and exclusive stack
> zones, and doing lookups of zero conf addresses for the zone from
> outside (both GZ, other NGZs, and other hosts), and for other hosts from
> within the zones.
> 
> If you plan to review this but want time, please let me know so that I
> can wait for you.
> 
> Thanks, 
> 
> -- Rich
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer