[illumos-Developer] missing lwp_exit() in kcfpool_svc()

[Garrett D'Amore]

I've added this comment (but not updated the webrev):

                         /*
                          * lwp_exit() assumes it is called
                          * with the proc lock held.  But the
                          * first thing it does is drop it. 
                          * This ensures that lwp does not
                          * exit before lwp_create is done
                          * with it.
                          */
                          mutex_enter(&curproc->p_lock);
                          lwp_exit();	/* does not return */


Hopefully that is what you were looking for.

	- Garrett

On Fri, 2011-04-01 at 15:26 -0400, Dan McDonald wrote:
> On Fri, Apr 01, 2011 at 11:51:18AM -0700, Garrett D'Amore wrote:
> > 
> >  Webrev with the fix is at
> > http://mexico.purplecow.org/gdamore/webrev/kcf-fix/
> > 
> 
> It might be instructive to have a small comment about why you're acquiring
> curproc->p_lock prior to calling lwp_exit().
> 
> Otherwise, ship it!
> 
> Dan
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer