[illumos-Developer] code review: 849 domain controller "hot fail over" can take forever

[Garrett D'Amore]

  Generally it looks ok.  But there is no reason to explicitly state 
"extern"  on smbdr.h line 261.  When located in a header file, external 
linkage is the default.  Otherwise ship it.

     - Garrett

On 04/ 4/11 10:02 PM, Albert Lee wrote:
> On Mon, Apr 4, 2011 at 7:08 PM, Gordon Ross<gordon.w.ross at gmail.com>  wrote:
>> Looks like I forgot to send out a code review request for this:
>>
>> issue: https://www.illumos.org/issues/849
>> webrev: http://cr.illumos.org/view/xmjid46h/
>>
>> It's not beautiful, but solves the main problems.
>>
>> I have more work coming in this area that will replace much of
>> this code with a better outbound connection manager.
>> (i.e. one that can handle concurrent outbound calls,
>> and that supports extended security, etc )
>>
>> Thanks,
>> Gordon
>>
> Looks fine. I think these are identical to the changes I reviewed for Nexenta.
>
> -Albert
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer