[illumos-Developer] [REVIEW] 754 Build of illumos-gate fails with perl-5.10.0 as default perl

Gordon Ross gordon.w.ross at gmail.com
Fri Apr 8 07:26:54 PDT 2011


Looks good to me.

On Fri, Apr 8, 2011 at 12:50 AM, Richard Lowe <richlowe at richlowe.net> wrote:
> I'd like review for
>   754 Build of illumos-gate fails with perl-5.10.0 as default perl
> webrev:
>  http://richlowe.net/webrevs/il_754
>
> Use of IO::Dir gets us a reference rather than a filehandle, and lets
> us scope it correctly so we don't clobber it on the way down the
> directory tree.
>
> I've run a successful build with perl 5.8.4, Gordon's run a build with 5.10.0
>
> Thanks,
>
> -- Rich
>



More information about the Developer mailing list