[illumos-Developer] WEBREV 706 beadm should accept 'umount' as well as 'unmount'
Albert Lee
trisk at opensolaris.org
Mon Apr 11 15:09:52 PDT 2011
On Mon, Apr 11, 2011 at 5:49 PM, Alexander Stetsenko <ams at nexenta.com> wrote:
> On 04/10/2011 04:58 AM, Gordon Ross wrote:
>>
>> On Sat, Apr 9, 2011 at 3:59 PM, Alexander Stetsenko<ams at nexenta.com>
>> wrote:
>>>
>>> On 04/09/2011 09:56 PM, Richard Lowe wrote:
>>
>> [...]
>>>>
>>>> The changes at lines 263 and 320 seem like they're fixing some other
>>>> bug(s), which should be filed and included in your commit message.
>>>
>>> There is no tickets for them.
>>> Both were found while I was working on 719 (which was later completed by
>>> Alex Eremin)
>>
>> I brought that up too. Normally, one should file separate bugs for other
>> issues like that, but these are close enough that I'd be willing to let it
>> go
>> as part of issue 706, as long as you will describe the "also fixed" items
>> in that bug. Please update 706 (or file more issues)
>
> I`d prefer to not make new tickets.
>
> after you push it I`ll update issue 706 as resolved and describe what was
> "also fixed",
> did I understand you correctly ?
>
You need to describe the issues you're addressing before we can accept
those changes.
-Albert
More information about the Developer
mailing list