[illumos-Developer] CODE REVIEW --> #935, sv_lyr_open() uses NULL pointers...

Garrett D'Amore garrett at nexenta.com
Wed Apr 20 08:00:29 PDT 2011


Looks good to me.  Ship it!

	- Garrett

On Wed, 2011-04-20 at 10:46 -0400, Dan McDonald wrote:
> A Nexenta customer found this, and Nexenta's own Yuri Pankov proved the
> problem is also in Illumos.
> 
> One of the inherited-from-NWS subsystems has an interesting way of working
> either with or without certain state.  Problem is, it calls rw_exit() without
> checking for this state.  Without commenting on the overall architecture,
> I've managed to fix this particular shortcoming.
> 
> 	http://www.kebe.com/~danmcd/webrevs/935/
> 
> I cleaned up the one function a little too w.r.t. cstyle/readability, but the
> important part is not calling rw_exit(0x8) anymore.
> 
> Thanks,
> Dan
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer





More information about the Developer mailing list