[illumos-Developer] [REVIEW] 939 SUNWdtrt needs to be willing to use 64bit java

[Albert Lee]

On Thu, Apr 21, 2011 at 7:31 PM, Richard Lowe <richlowe at richlowe.net> wrote:
> I'd like review for:
>  939 SUNWdtrt needs to be willing to use 64bit java
>
> webrev:
>  http://richlowe.net/webrevs/il_939
>
> Tests of the DTrace Java API had an implicit assumption that the
> target process would be 32bit (the same as the java interpretter).
> Since ksh is run under isaexec, this assumption stopped holding,
> breaking a handful of the tests when run on a 64bit system.  This
> changes the jdtrace wrapper such that it will attempt to execute
> /usr/java/bin/<64bitname>/java, falling back to /usr/java/bin/java on
> 32bit systems (but, importantly _not_ falling back on 64bit systems),
> which seems more robust than attempting to keep all the tests
> presenting 32bit targets.   This introduces a dependency on
> runtime/java/runtime64 (the dependency on 32bit runtime already
> existed logically, but wasn't in the package, so I added that too).
>
> -- Rich
>

Seems reasonable for the test, although given you depend on runtime64
I don't think you have to worry about falling back on 64-bit if you
used isaexec.

-Albert