[illumos-Developer] CODE REVIEW -> Illumos 915, compliments of Joyent

[Garrett D'Amore]

On Thu, 2011-04-21 at 16:58 -0400, Gordon Ross wrote:
> Looks good to me.
> 
> I suggest doing:
>    hg recommit -u "Bryan Cantrill <...>"
> with the usual:
>   Reviewed by: Dan McDonald ...
>   Reviewed by: ...
> 
> In general, for contributed changes, we should try to make the
> commit user (reci -u ...) the same as in the contributed change set.

Yes please!

	- Garrett

> 
> Gordon
> 
> On Thu, Apr 21, 2011 at 4:19 PM, Dan McDonald <danmcd at nexenta.com> wrote:
> > Hello folks!
> >
> > The observent in the audience know I filed bugs 915-918 to cover TCP/IP
> > changes in the Joyent wad that was recently published.
> >
> > Here's the official review for the first, 915.  It's a complete no-brainer,
> > and the only question is how to push it into Illumos: Contributed by Bryan,
> > reviewed by Dan + others?  Or Contributed by Dan, reviewed by Bryan + others?
> >
> > I don't care either way, modulo a slight leaning toward Contributed-by-Bryan,
> > but I would like a definitive answer.  This change is completely obvious and
> > clearly for the better.
> >
> >        http://www.kebe.com/~danmcd/webrevs/915/
> >
> > Joyent copyright, BTW, is included per the patch set handed to me out of the
> > Joyent wad.
> >
> > Please speak up!
> > Dan
> >
> > _______________________________________________
> > Developer mailing list
> > Developer at lists.illumos.org
> > http://lists.illumos.org/m/listinfo/developer
> >
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer