[illumos-Developer] CODE REVIEW -> Illumos 916, compliments of Joyent

[Garrett D'Amore]

Both changes look good to me, but again, ditch the "Originally" part of
the commit comment.

	- Garrett

On Thu, 2011-04-21 at 16:56 -0400, Dan McDonald wrote:
> The next changeset from Joyent (Jerry Jelinek, this time) focusses on
> false-sharing in the TCP stack, and raising some default fanout values:
> 
> 	http://www.kebe.com/~danmcd/webrevs/916/
> 
> I also have no problem with these set of changes.
> 
> I will WARN folks that there are other such closely-placed locks in the
> TCP/IP code.  Off the top of my head:
> 
> 	- connf_t (ipclassifier.h)
> 
> 	- irb_t  (ip.h)
> 
> 	- isaf_t  (sadb.h)
> 
> If anyone has a high-stress networking test rig (Hello Joyent?), please
> contact me here or off-list so we can talk about these other sources of
> false-sharing.
> 
> Again, please speak up so this changeset can go back!
> 
> Thanks,
> Dan
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer