[illumos-Developer] Webrev for bug 900: sed errors when -e is given a 0-length argument

[Robert Gordon]

On Apr 27, 2011, at 8:00 PM, Gordon Ross wrote:

> On Wed, Apr 27, 2011 at 8:24 PM, Gary Mills <mills at cc.umanitoba.ca> wrote:
>> This is for illumos bug 900: sed errors when -e is given a 0-length
>> argument.  My webrev is at:
>> 
>>   http://cr.illumos.org/view/vl7thda0/illumos900/
> 
> Thanks for debugging this.  Good find.  However,
> I think I'd prefer to see the asprintf preserved, and
> simply correct the check of it's return value, which
> should be like this:
> 
> 			if (asprintf(&temp_arg, "%s\n", optarg) < 0)
> 				err(1, "asprintf");

FWIW: I agree with Gordon

(and not just because he has a great first name :) ) 

Robert.
--
Robert Gordon 
rbg at copperegg.com