[illumos-Developer] Newbie webrev --> "ws" needs to set CLOSED_IS_PRESENT to no

[Roland Mainz]

On Wed, Feb 2, 2011 at 7:57 PM, Dan McDonald <danmcd at nexenta.com> wrote:
> I'm spinning up on Illumos proper, so please pardon any newbieness.
>
> I noticed the "ws" command doesn't set CLOSED_IS_PRESENT properly.  When I
> mentioned this to some Nexentians, their response was:  "Use bldenv".
>
> Instead, I took the bit of bldenv I wanted and placed it into "ws".  I'm not
> sure this is the best answer, though, because:
>
>        - If you're in a workspace with usr/closed created by an untarring of
>          the closed binaries, the test will set CLOSED_IS_PRESENT to yes.
>          I've noticed that elfsign is attempted if the variable isn't there,
>          and presumably it would also be attempted if it's set to yes.
>
>        - Longer-term, I'm wondering if the proper behavior should be to not
>          assume closed is there during the building of open.  That probably
>          has to wait until we've disentangled some more things.
>
> A *preliminary* webrev is here:
>
>        http://www.kebe.com/~danmcd/webrevs/fix-ws/

Technicially the patch looks good...
... as a side-note: ksh supports -v varname as "test" operator to
check if a variable _exists_ (regardless of type and content (and it
takes the name of the variable as argument and therefore avoids the
variable value expansion associated with '$')), e.g. you could use "if
[[ -v CLOSED_IS_PRESENT ]]; then" in your example.

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 3992797
 (;O/ \/ \O;)