[illumos-Developer] Review --> iSCSI UNMAP support

[Joerg Schilling]

Dan McDonald <danmcd at nexenta.com> wrote:

> Hello again!
>
> Sumit Gupta contributed some iSCSI changes so that we can support the UNMAP
> SCSI command.  This helps with ZFS sparse volumes servicing virtualized
> clients.
>
> Here's the webrev:
>
> 	http://www.kebe.com/~danmcd/webrevs/unmap/

I only had a quick look so far... please check:

	while (s & ((uint64_t)0xFFFFFFFF80000000)) {

The constant will first be truncated to an int and then extended to 64 bits.

0xFFFFFFFF80000000LL is apropriate to avoid such problems.

Jörg

-- 
 EMail:joerg at schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
       js at cs.tu-berlin.de                (uni)  
       joerg.schilling at fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/private/ ftp://ftp.berlios.de/pub/schily