[illumos-Developer] Review --> iSCSI UNMAP support

Dan McDonald danmcd at nexenta.com
Thu Feb 10 09:07:07 PST 2011


On Thu, Feb 10, 2011 at 06:05:14PM +0100, Joerg Schilling wrote:
> I only had a quick look so far... please check:
> 
> 	while (s & ((uint64_t)0xFFFFFFFF80000000)) {
> 
> The constant will first be truncated to an int and then extended to 64 bits.
> 
> 0xFFFFFFFF80000000LL is apropriate to avoid such problems.

Will fix, good catch.

Thanks,
Dan



More information about the Developer mailing list