[illumos-Developer] WEBREV: 434 kernel crash dump on comstar iscsit

Garrett D'Amore garrett at damore.org
Thu Feb 17 08:34:25 PST 2011


  I remember this webrev now. :-)

Can you describe your testing?  Also, a mail_msg from a nightly build 
and output from hg pbchk would be good.

I would like to get one more reviewer on this, if at all possible.

     - Garrett

On 02/17/11 08:22 AM, Alexander Stetsenko wrote:
> This webrev seems to be stale.
> Please, review it again.
> http://cr.illumos.org/view/2y5oj5em/
>
> On 01/17/2011 04:46 PM, Alexander Stetsenko wrote:
>>
>> Webrev link is here:
>>
>> http://cr.illumos.org/view/2y5oj5em/
>>
>> This fixes crash of comstar when multiple parallel iscsi target 
>> creation requests happen.
>>
>> Crash happened because of there was stale requests in active/waiting 
>> queues,
>> for instance - ONLINE request after DELETE request, DELETE request 
>> removed object (iscsi target)
>> and released its memory, so while ONLINE request processing it 
>> referred to freed memory or tried
>> to "hold"  going to die iscsi target object.
>>
>> Fix is to remove stale requests from active queue while iscsitgt 
>> object is going to be destroyed.
>> (waiting queue was removed at all)
>>
>> A crash is easily reproduced on hw multicore machine.
>>
>>
>>
>>
>> _______________________________________________
>> Developer mailing list
>> Developer at lists.illumos.org
>> http://lists.illumos.org/m/listinfo/developer
>




More information about the Developer mailing list