[illumos-Developer] WEBREV: 434 kernel crash dump on comstar iscsit

[Dan McDonald]

On Thu, Feb 17, 2011 at 07:22:27PM +0300, Alexander Stetsenko wrote:
> This webrev seems to be stale.
> Please, review it again.
> http://cr.illumos.org/view/2y5oj5em/

You've certainly made this code MUCH easier to read (by factoring out
stmf_svc_timeout()).

You did make one other change that may surprise users, unless the old
behavior is part of the bug: the stmf_svc_queue() function now literally is a
queue --> you append new ones at the end.  Formerly, this was a stack (new
ones placed at the front of the line).  It seems like a good fix to me,
though.

I say ship it.

Dan