[illumos-Developer] NOW with zvol-only zfs diffs --> iSCSI UNMAP

[Dan McDonald]

Thank you folks!

On Sun, Feb 20, 2011 at 01:58:35PM -0800, Garrett D'Amore wrote:
> On Sun, 2011-02-20 at 15:47 -0500, Eric Schrock wrote:
<SNIP!>
> > Seems a little strange to use 'extpart_info'; we should probably do
> > something like:
> > 
> > 
> > typedef struct dkioc_free {
> >         diskaddr_t df_start;
> >         diskaddr_t df_length;
> > } dkioc_free_t;
> > 
> 
> Agreed. :-)  I'd also add a "flags" field for possible future expansion.
> (I'm thinking that we might want a flag for"immediate" free vs. deferred
> garbage collection, for example.  There might be other flags to indicate
> whether a "data deletion" guarantee is required as well.  Those are all
> future ideas though, which is why I propose to leave them as a flags
> field.)

I can see multiple kinds of delete happening too, so let's try this:

	typedef struct dkioc_free_s {
		uint32_t df_flags;
		uint32_t df_reserved;	/* For 64-bit goodness below... */
		diskaddr_t df_start;
		diskaddr_t df_length;
	};

Watch for code changes late tonight or sometime Monday.

Dan