[illumos-Developer] iSCSI UNMAP with DKIOCFREE

Dan McDonald danmcd at nexenta.com
Mon Feb 21 08:42:18 PST 2011


On Sun, Feb 20, 2011 at 05:16:08PM -0500, Dan McDonald wrote:
<SNIP!>

> I can see multiple kinds of delete happening too, so let's try this:
> 
> 	typedef struct dkioc_free_s {
> 		uint32_t df_flags;
> 		uint32_t df_reserved;	/* For 64-bit goodness below... */
> 		diskaddr_t df_start;
> 		diskaddr_t df_length;
> 	};
> 
> Watch for code changes late tonight or sometime Monday.

It's "sometime Monday", and there they are:

	http://www.kebe.com/~danmcd/webrevs/unmap/

I only have one KEBE comment left, and it's more for the iSCSI types (do I
honor the DISABLE_WRITE_CACHE flag enough to enable txg_wait_sync() or not?).

Thanks!
Dan



More information about the Developer mailing list