[illumos-Developer] iSCSI UNMAP with DKIOCFREE

[George Wilson]

More comments:

zvol.c:

You're going to have to change the flow the if/else block to accommodate 
some of these comments:

line# 1532 - you should be able to just set this to ZVOL_OBJ
after line# 1690 - you need to do dmu_tx_commit()
after line# 1694 - you need to a zil_commit() but only if error != 0

line # 407 - you need to define a new replay op

Thanks,
George

On 2/23/11 1:59 PM, Dan McDonald wrote:
> On Wed, Feb 23, 2011 at 12:12:18PM -0800, George Wilson wrote:
>> On 2/23/11 11:59 AM, Dan McDonald wrote:
>>> On Wed, Feb 23, 2011 at 09:38:47AM -0800, George Wilson wrote:
>>>> Dan,
>>>>
>>>> The latest changes look good. I've also finished looking at
>>>> dmu_free_long_range() and as feared we're going to need to log an
>>>> intention for this in the zil so that we can replay this if a  crash
>>>> were ever to happen.
>>> So I see two possibilities after an initial exploration:
>>>
>>> 1.) Have DKIOCFREE code do a distinct ZIL intention.  I see two possible
>>>      places...
> <SNIP!>
>
>> I think the above is the cleanest way.
> I've changes that compile and lint, but I won't be testing them until after
> dinner.  These are subject to smoke-test results, but here they are:
>
> 	http://www.kebe.com/~danmcd/webrevs/unmap/
>
> and keep focussed on zvol.c.
>
> Thanks!
> Dan
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer