[illumos-Developer] iSCSI UNMAP with DKIOCFREE
Dan McDonald
danmcd at nexenta.com
Wed Feb 23 17:53:57 PST 2011
Smoke test blew up, THEN I read mail...
On Wed, Feb 23, 2011 at 03:37:12PM -0800, George Wilson wrote:
> More comments:
>
> zvol.c:
>
> You're going to have to change the flow the if/else block to
> accommodate some of these comments:
>
> line# 1532 - you should be able to just set this to ZVOL_OBJ
> after line# 1690 - you need to do dmu_tx_commit()
> after line# 1694 - you need to a zil_commit() but only if error != 0
>
> line # 407 - you need to define a new replay op
Fixed, fixed, fixed, and fixed.
Webrev's updated:
http://www.kebe.com/~danmcd/webrevs/unmap/
I'm now gonna reboot and re-smoke-test. If I find more, I'll update (so try
reload before sending mail, just in case... ;).
Thanks for your time & patience,
Dan
More information about the Developer
mailing list