[illumos-Developer] Requesting code review for opensource /usr/xpg4/bin/more replacement with "less" ...

[I. Szczesniak]

On Mon, Jan 17, 2011 at 3:15 PM, Roland Mainz <roland.mainz at nrubsig.org> wrote:
> Hi!
>
> ----
>
> Below are the webrev(s) which integrate the "less" utility as
> opensource replacement for /usr/xpg4/bin/more. The same webrev
> provides the usual "less" utilities.
>
> The webrev come in two flavors:
>
> 1. "less" compiled with plain regex API:
> http://cr.opensolaris.org/~gisburn/illumos_b520_xpg4more_plainregex/
>
> 2. "less" compiled with an extended regex API which allows alternative
> pattern systems to be used in searches, e.g. (?P)pattern for perl
> pattern, (?Si)pattern for case-insensitive shell patterns etc.:
> http://cr.opensolaris.org/~gisburn/illumos_b520_xpg4more_perlregex/
>
> Notes:
> - The code provides /usr/bin/less, /usr/bin/lessecho and
> /usr/bin/lesskey and a softlink from /usr/xpg4/bin/more to
> ../../bin/less (=/usr/bin/less) as part of the base packages
> - "less" will switch to POSIX "more" mode when launched as "more"
> - The code is compiled with XPG6 flags to make sure XPG[64] version of
> matching libc calls are made (e.g. XPG4 version of |system()|) to
> ensure POSIX conformance.
>
> ToDo:
> - Make a choice which regex engine we'll use
> - There is one issue with multibyte characters I'm currently investigating
> - Integrate review feedback

Why is less.man not part of the package?

Except that issue the changes look good to me.

Irek