[illumos-Developer] Review for #429 iostat -E does not report serial number

Garrett D'Amore garrett at nexenta.com
Thu Jan 20 11:33:56 PST 2011


On Thu, 2011-01-20 at 22:23 +0300, Alexander Eremin wrote:
> Requesting code review for #429 iostat -E does not report serial number
> webrev: http://cr.opensolaris.org/~alhazred/illumos-gate-stat/
> 
> 
> Thanks,
> Alexander
> 


Looks good to me.  I see no reason that serial numbers should be
restricted to Sun drives.

I kind of am not thrilled about the special handling for Sun qualified
drives in this driver .. it may be time to go back and re-examine all
that logic throughout the sd driver.

	- Garrett




More information about the Developer mailing list