[illumos-Developer] Review for #429 iostat -E does not report serial number

Alexander Eremin alexander.r.eremin at gmail.com
Thu Jan 20 11:47:59 PST 2011


On Jan 20, 2011, at 10:33 PM, Garrett D'Amore wrote:

> On Thu, 2011-01-20 at 22:23 +0300, Alexander Eremin wrote

> Requesting code review for #429 iostat -E does not report serial  
> number
>>
>> webrev: http://cr.opensolaris.org/~alhazred/illumos-gate-stat/
>>
>>
>> Thanks,
>> Alexander
>>
>
>
> Looks good to me.  I see no reason that serial numbers should be
> restricted to Sun drives.
>
> I kind of am not thrilled about the special handling for Sun qualified
> drives in this driver .. it may be time to go back and re-examine all
> that logic throughout the sd driver.
>
> 	- Garrett
>

Yes, it seems it's a  question for other  parts like devid, etc.
We must return later and check  special "SUN"-related code more widely.

Thanks
Alexander




More information about the Developer mailing list