[illumos-Developer] Code review for illumos #657 and #658

[Garrett D'Amore]

Approved, you may push this change.  And welcome to the community of
illumos developers/committers!

	- Garrett

On Tue, 2011-01-25 at 16:16 +0000, Andrzej Szeszo wrote:
> Thanks Garrett
> 
> Yes, I agree to a) and b) below assuming you actually meant 'with an 
> approval' and not
> 'without approval' of an Advocate.
> 
> And yes, aszeszo is my illumos.org account.
> 
> Cheers,
> 
> Andrzej
> 
> On 01/25/11 15:35, Garrett D'Amore wrote:
> > The RTI looks good, but as this is your first integration, I need you to
> > agree to the following two items before I enable your account:
> >
> > a) You understand and agree to abide by our integration rules for all
> > integrations, which means that code shall be pushed to the official
> > illumos repository without approval of an Advocate.  (Current advocates
> > are me, richlowe, gwr, and trisk.)
> >
> > b) You agree that all contributions you make will be for code that you
> > have the right to contribute, either because you own the intellectual
> > property associated with it, or because you have approval to do so from
> > the owner.
> >
> > Thanks.  Once you've acknowledged and agreed to the above, then I will
> > enable your account (aszeszo right?) to push, and you will be able to
> > push these changes.
> >
> > 	- Garrett
> >
> > On Mon, 2011-01-24 at 18:04 +0000, Andrzej Szeszo wrote:
> >> Thanks Garrett
> >>
> >> Full build mail_msg attached. None of the warnings in the mail_msg were
> >> caused by my changes.
> >>
> >> I have installed new packages and ran "LANG=.... date" to check if new
> >> locales work.
> >>
> >> hg pbchk and hg outgoing -v output below:
> >>
> >> [aszeszo at ultra illumos]$ hg pbchk
> >> Copyright check:
> >> usr/src/cmd/localedef/data/bs_BA.UTF-8.src: no copyright claim for current year found
> >> usr/src/cmd/localedef/data/sl_SI.UTF-8.src: no copyright claim for current year found
> >>
> >> C style check:
> >>
> >> Header format check:
> >>
> >> Java style check:
> >>
> >> Mapfile comment check:
> >>
> >> File permission check:
> >>
> >> Keywords check:
> >>
> >> Comments check:
> >>
> >> Checking for new tags:
> >>
> >> Checking for multiple heads (or branches):
> >>
> >> Checking for branch changes:
> >>
> >> Checking for uncommitted changes:
> >>
> >> Checking for merges:
> >>
> >> [aszeszo at ultra illumos]$ hg outgoing -v
> >> running ssh anonhg at hg.illumos.org "hg -R illumos-gate serve --stdio"
> >> comparing with ssh://anonhg@hg.illumos.org/illumos-gate
> >> searching for changes
> >>
> >> changeset:   13274:6148e78f7f64
> >> tag:         tip
> >> user:        Andrzej Szeszo<aszeszo at gmail.com>
> >> date:        Mon Jan 24 18:03:29 2011 +0000
> >>
> >> description:
> >>           657 Need bosnian locale support
> >>           658 Need slovenian locale support
> >>           Reviewed by: gdamore at nexenta.com
> >>           Reviewed by: trisk at nexenta.com
> >>
> >> modified:
> >>      usr/src/cmd/localedef/Makefile
> >> added:
> >>      usr/src/cmd/localedef/data/bs_BA.UTF-8.src
> >>      usr/src/cmd/localedef/data/sl_SI.UTF-8.src
> >>      usr/src/pkg/manifests/locale-bs.mf
> >>      usr/src/pkg/manifests/locale-sl.mf
> >>
> >> [aszeszo at ultra illumos]$
> >>
> >>
> >>
> >>
> >> OK to integrate?
> >>
> >> Cheers,
> >>
> >> Andrzej
> >>
> >>
> >> On 01/23/11 23:01, Garrett D'Amore wrote:
> >>> This looks quite good to me, although I have to take your use of of the
> >>> CLDR data at face value since I can read neither Bosnian nor
> >>> Slovenian. :-)
> >>>
> >>> 	- Garrett
> >>>
> >>> On Sun, 2011-01-23 at 17:13 +0000, Andrzej Szeszo wrote:
> >>>> Hi all
> >>>>
> >>>> Please review http://cr.illumos.org/view/r3b0863l
> >>>>
> >>>> This is a simple addition of bosnian and slovenian locale data. I took
> >>>> the locale source files from the standard cldr distribution.
> >>>>
> >>>> Regards,
> >>>>
> >>>> Andrzej
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> Developer mailing list
> >>>> Developer at lists.illumos.org
> >>>> http://lists.illumos.org/m/listinfo/developer
> >
> 
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer