[illumos-Developer] 1073-r1

[Adam Leventhal]

Hey Bayard,

> usr/src/uts/i86pc/cpr/Makefile
>       58 +#       bootdev is marginal because the only explicitly identified
>       59 +#       dependency is for SPARC-specific code.
> I'm confused by that comment. Can you elaborate?
>
> This is an attempt to preserve in some form the original comment in cpr.c:
> char _depends_on[] = "misc/bootdev";     /* i_devname_to_promname() */
> IIRC the referenced symbol is only relevant to SPARC. I was slightly
> sceptical that this was the whole truth, so I tried to comment to that
> effect. I'm open to suggestions for a better gloss or a correction of the
> understanding that led me to this summary.

The comment just adds more confusion. How about something like this:
The dependency on bootdev is required because of the use of <name of
symbol>. The use of this may only be necessary on SPARC; removing its
use would eliminate the need for the dependency on bootdev.

Looks good to me.

Adam

-- 
Adam Leventhal, Delphix
http://dtrace.org/blogs/ahl

275 Middlefield Road, Suite 50
Menlo Park, CA 94025
http://www.delphix.com