[illumos-Developer] initial review: bombproof taskq dispatch

Dan McDonald danmcd at nexenta.com
Thu Jul 7 07:24:49 PDT 2011


On Thu, Jul 07, 2011 at 07:21:00AM -0700, George Wilson wrote:

<SNIP!>

> - In taskq_thread(), line# 1582, this comment is confusing since we
> don't really talk about prealloc'd tasks and may get confused with
> prealloced taskqs which are mentioned in this file. I have to admit
> that this interface is a little funky and I'm wondering if we
> shouldn't try to better define this. Maybe something like
> taskq_ent_create() and taskq_ent_destroy() that can be called by
> external consumers?

I thought the whole idea was that one could embed a taskq_ent inside their
existing data structure if needed.  If the only interface for
creation/deletion is a distinct allocator, we lose that advantage.

If I'm wrong about the embedding, you may kindly ignore this response.

Dan



More information about the Developer mailing list