[illumos-Developer] initial review: bombproof taskq dispatch

[Garrett D'Amore]

On Jul 7, 2011, at 7:24 AM, Dan McDonald <danmcd at nexenta.com> wrote:

> On Thu, Jul 07, 2011 at 07:21:00AM -0700, George Wilson wrote:
> 
> <SNIP!>
> 
>> - In taskq_thread(), line# 1582, this comment is confusing since we
>> don't really talk about prealloc'd tasks and may get confused with
>> prealloced taskqs which are mentioned in this file. I have to admit
>> that this interface is a little funky and I'm wondering if we
>> shouldn't try to better define this. Maybe something like
>> taskq_ent_create() and taskq_ent_destroy() that can be called by
>> external consumers?
> 
> I thought the whole idea was that one could embed a taskq_ent inside their
> existing data structure if needed.  If the only interface for
> creation/deletion is a distinct allocator, we lose that advantage.
> 
> If I'm wrong about the embedding, you may kindly ignore this response.

You are not wrong.  I could also create the creat and destroy interfaces for a potential future public api, as we do not want to hard wire the size of the task entry into binaries that are not part of the consolidation. 

I will respond to Georges other comments later today.

  - Garrett
> 
> Dan
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer