[illumos-Developer] Review 693

[Igor Kozhukhov]

Hi Alex,

About 'OWNED_BY '
It is variable not using now - it was in original Makefile, but I have
changed variables to top Makefiles.
I'll remove unused variables.

About src/i386/amd64 - it is original structure for sources.
As you can see primary lib directory jave the same structure with LIBC:
libm$ ls -1
amd64
i386
inc
Makefile
src

libc$ ls -1
amd64
capabilities
common
extract-copyright
extract-copyright.pl
i386
i386_hwcap1
i386_hwcap2
i386_hwcap3
inc
Makefile
Makefile.targ
makelibccatalog.sh
port
README
req.flg
sparc
sparcv9
THIRDPARTYLICENSE
THIRDPARTYLICENSE.descrip

It is not mistake - it is the same with other libs.
'src' directory have original structure.
At this moment it is first integration and we can change what we need later
- maybe update to new versions, maybe restructure if needed.

I'll put some diff's with original sources a little later to webrev and
update review.

-Igor

> From: Alexander Eremin <alexander.eremin at nexenta.com>
> Date: Wed, 13 Jul 2011 17:09:28 +0400
> To: Igor Kozhukhov <ikozhukhov at gmail.com>
> Cc: "developer at lists.illumos.org" <developer at lists.illumos.org>
> Subject: Re: [illumos-Developer] Review 693
> 
> Hi Igor,
> 
> Makefiles contains many definitions which already defined in top
> Makefiles
> and many of them not needed at all (like OWNED_BY for example).
> 
> Also path like src/i386/amd64 looks ugly. Library directory usually
> contains:
> i386
> amd64
> sparc
> common (where inc, LD, m9x, etc)
> 
> usr/src/lib/README.mapfiles can help you.