[illumos-Developer] Review 693

[Alexander Eremin]

On Jul 13, 2011, at 3:12 PM, Igor Kozhukhov wrote:

> Hello All,
>
> Please review : integration Sun Devpro Math Library to illumos tree  
> (693)
>
> http://igork.vlds.ru/nexenta/cr/illumos-693-webrev/
>
> What have been done:
> 1. integrated LIBM to illumos build for intel i386 and amd64
> 2. fixed compilation issues in packages for using headers from  
> integrated
> LIBM
> Package system/library/math/header-math
> with headers have been removed from system and build was using  
> integrated
> LIBM headers
>
> This LIBM have been tested on OI-151 and NCP4.
>
> This version of LIBM don't have libmtsk*
>
> ---
> Best regards,
> Igor Kozhukhov
> Skype# igor.kozhukhov | IRC# igork
>
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer

Hi Igor,

Makefiles contains many definitions which already defined in top  
Makefiles
and many of them not needed at all (like OWNED_BY for example).

Also path like src/i386/amd64 looks ugly. Library directory usually  
contains:
i386
amd64
sparc
common (where inc, LD, m9x, etc)

usr/src/lib/README.mapfiles can help you.


Thanks,
:: Alexander