[illumos-Developer] webrev for 635, 1181, 1188-1192
Gordon Ross
gordon.w.ross at gmail.com
Wed Jul 13 15:49:09 PDT 2011
>> usr/src/cmd/tcpd/Makefile
>> Why the "white space" changes? (remove space before =)
>> (Took me a few seconds to figure out that was what changed on those lines:)
>
> Not really intentional, slipped in as I was making other whitespace
> changes to make everything look the same (used to having VAR=, can change
> them back if needed).
No big deal. There's no style guidance on that, so I'd probably just
leave those lines as they were.
>> usr/src/man/man3/Makefile
>> Not sure about the "so" link for libwrap.3
>> Does libwrap need to be in the NAME section of host_access.3 then?
>
> Probably, I just moved the manpage and created the .so link, as it was
> originally done in cmd/tcpd. I'm not sure about adding the libwrap to
> NAME section - it wasn't there before, so no content changes here.
I think the names listed in the NAME section are supposed to
correlate with the SO links pointing to the man page.
Maybe Rich Lowe will comment on that.
Gordon
More information about the Developer
mailing list