[illumos-Developer] Review 1116,1208, 1154

Dan McDonald danmcd at nexenta.com
Thu Jul 14 08:01:45 PDT 2011


On Thu, Jul 14, 2011 at 06:49:34PM +0400, Alexander Eremin wrote:
> I'd like review for next fixes:
> 
> 1116 beadm *_snap commands shouldn't exist
> 1208 beadm doesn't show BE snapshots
> 
> webrev: http://cr.illumos.org/view/7zjkkv35/

The code changes here are okay, BUT may you please update the 1116 bug report
to include examples of existing commands that are equivalent to *_snap so
when folks wonder what to do, they have an option?  Perhaps a man-page update
in the EXAMPLES section would address my concern as well?

Basically, I want documentation of some sort demonstrating existing
equivalent functionality to what you're deleting.  Apart from that, shipping
it is fine.

> 1154 cpio needs a quiet option
> 
> webrev: http://cr.illumos.org/view/ju1r6k7n/

This one looks fine, ship it.

Thanks,
Dan



More information about the Developer mailing list