[illumos-Developer] Review 1116,1208, 1154

[Alexander Eremin]

Hi Dan,

On Jul 14, 2011, at 7:01 PM, Dan McDonald wrote:

> On Thu, Jul 14, 2011 at 06:49:34PM +0400, Alexander Eremin wrote:
>> I'd like review for next fixes:
>>
>> 1116 beadm *_snap commands shouldn't exist
>> 1208 beadm doesn't show BE snapshots
>>
>> webrev: http://cr.illumos.org/view/7zjkkv35/
>
> The code changes here are okay, BUT may you please update the 1116  
> bug report
> to include examples of existing commands that are equivalent to  
> *_snap so
> when folks wonder what to do, they have an option?  Perhaps a man- 
> page update
> in the EXAMPLES section would address my concern as well?
>

Deleted commands was undocumented and not included in man.
Man page already contains examples for creating and destroying
snapshots:
Example 3 and Example 12.

> Basically, I want documentation of some sort demonstrating existing
> equivalent functionality to what you're deleting.  Apart from that,  
> shipping
> it is fine.
>
>> 1154 cpio needs a quiet option
>>
>> webrev: http://cr.illumos.org/view/ju1r6k7n/
>
> This one looks fine, ship it.
>
> Thanks,
> Dan
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer


Thanks for reviewing,

:: Alexander