[illumos-Developer] Webrev for bug 561: Strange characters when executing "format"

Gary Mills mills at cc.umanitoba.ca
Thu Jul 21 10:27:52 PDT 2011


On Thu, Jul 21, 2011 at 11:24:14AM -0400, Albert Lee wrote:
> On Thu, Jul 21, 2011 at 10:28 AM, Jason King <jason.brian.king at gmail.com> wrote:
> > LGTM
> >
> > On Thu, Jul 21, 2011 at 8:06 AM, Gary Mills <mills at cc.umanitoba.ca> wrote:
> >>
> >> Any interest in this one?  I've had no reviews of the revised webrev
> >> so far.
> 
> Don't think you actually have to add the #include to the header, since
> the parameters are just struct pointers.

I had to add it because the function prototype for
get_generic_disk_name() specifies the `scsi_inquiry' struct.  The
compiler needed to know the definition of that struct for proper error
checking.

-- 
-Gary Mills-        -Unix Group-        -Computer and Network Services-



More information about the Developer mailing list