[illumos-Developer] Webrev for bug 561: Strange characters when executing "format"

[Gordon Ross]

>> Don't think you actually have to add the #include to the header, since
>> the parameters are just struct pointers.
>
> I had to add it because the function prototype for
> get_generic_disk_name() specifies the `scsi_inquiry' struct.  The
> compiler needed to know the definition of that struct for proper error
> checking.

It would be sufficient to add this line:
   struct scsi_inquiry;                  /* anonymous struct here */
instead of the include sys/scsi/scsi.h

(and somewhat preferable, if this has no other reason to include that)

Gordon