[illumos-Developer] webrev for 1108

Gordon Ross gordon.w.ross at gmail.com
Mon Jun 13 06:15:58 PDT 2011


On Mon, Jun 13, 2011 at 1:01 AM, Dan Kruchinin <dkruchinin at acm.org> wrote:
> On Mon, Jun 13, 2011 at 7:43 AM, Richard Lowe <richlowe at richlowe.net> wrote:
>> I would expect the XXX comments regarding EBUSY to be resolved in one
>> direction or another (either set the error, or remove the comment,
>> whichever is correct).
>
> I'm not sure that an answer on the question what error code should be
> set if endpoint is closing can be found fast.
> There definitely must be the code reporting an error, but we need to
> choose the error code STREAMS familiar with. (i.e. it should
> know how to deal with it).

I thought we had this resolved.  I looked at the code handling the
te_closing flag and concluded that there's nowhere to send an
error reply to after te_closing has been set, because the close
function for the endpoint has been called.

My understanding is that we can see these messages when
tl_addr_ack is called via the serializer because that can cause
us to wait, and by the time we're done waiting, the end point may
have closed.

So I say, just remove those XXX comments.
No need for a new issue.

Gordon



More information about the Developer mailing list