[illumos-Developer] webrev for 1108

[Garrett D'Amore]

On Mon, 2011-06-13 at 09:15 -0400, Gordon Ross wrote:
> On Mon, Jun 13, 2011 at 1:01 AM, Dan Kruchinin <dkruchinin at acm.org> wrote:
> > On Mon, Jun 13, 2011 at 7:43 AM, Richard Lowe <richlowe at richlowe.net> wrote:
> >> I would expect the XXX comments regarding EBUSY to be resolved in one
> >> direction or another (either set the error, or remove the comment,
> >> whichever is correct).
> >
> > I'm not sure that an answer on the question what error code should be
> > set if endpoint is closing can be found fast.
> > There definitely must be the code reporting an error, but we need to
> > choose the error code STREAMS familiar with. (i.e. it should
> > know how to deal with it).
> 
> I thought we had this resolved.  I looked at the code handling the
> te_closing flag and concluded that there's nowhere to send an
> error reply to after te_closing has been set, because the close
> function for the endpoint has been called.
> 
> My understanding is that we can see these messages when
> tl_addr_ack is called via the serializer because that can cause
> us to wait, and by the time we're done waiting, the end point may
> have closed.
> 
> So I say, just remove those XXX comments.
> No need for a new issue.

I would possibly add a comment clarifying this above the freemsg calls,
like:  /* Stream closing, nowhere we can send this message. */

  - Garrett

> 
> Gordon
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer