[illumos-Developer] webrev for 1107

[Vitaliy Gusev]

On 06/13/2011 06:43 PM, Gordon Ross wrote:
> I've seen this before, and I'm happy with most of it...
>
> But one question now comes to mind:  This code is shared with
> the nfsd listener (etc.) so I wonder, how did it work with the check;
>    if (retnconf->nc_semantics == NC_TPI_CLTS) ... ?
> Seems like that should have broken NFS[3,4] over TCP.


Connection oriented protocols are initialized via cots_listen_event() 
that is called from poll_for_action().


So, Dan, Why did you change it with OK_TPI_TYPE?

-        if (retnconf->nc_semantics == NC_TPI_CLTS) {
+        if (OK_TPI_TYPE(retnconf)) {


It needs to be initialized directly only for connectionless protocols (UDP).


> Would be good to understand why that was there.
>
> On Sun, Jun 12, 2011 at 10:31 PM, Dan Kruchinin<dkruchinin at acm.org>  wrote:
>> While working on NFS lock manager I found two bugs/issues in illumos.
>> Here is the first one.
>> The patch makes do_one() function of nfs_tbind.c able to work with
>> loopback device (/dev/ticotsord) provider.
>> We need it for lockd daemon. It uses loopback device to communicate
>> with kernel part of network lock manager.
>
> BTW, it's used by the in-kernel part of the lock manager to
> communicate with the user-space NFS status monitor.
> (This code pre-dates doors, door up-calls, etc.)  We could
> change it use a different mechanism, but we'd prefer to
> minimize the scope of this work as much as possible.
> (At least for now.)
>
> Gordon
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer