[illumos-Developer] webrev: #725 apic_grp_set_cpu misorders checkfor FIXED interrupts

Dan Kruchinin dkruchinin at acm.org
Sat Jun 18 12:47:27 PDT 2011


On Sat, Jun 18, 2011 at 11:03 PM, Albert Lee <trisk at opensolaris.org> wrote:
> Dan, if you don't mind, I'd like to have a second person review this
> before it gets approved -- I can do the review myself later today.

Yes, sure, it'd be great.

>
> -Albert
>
> On Fri, May 13, 2011 at 1:09 AM, Garrett D'Amore <garrett at nexenta.com> wrote:
>> I think I already responded but this looks good.
>>
>>  -- Garrett D'Amore
>>
>> On May 10, 2011, at 5:02 AM, "Dan Kruchinin" <dkruchinin at acm.org> wrote:
>>
>>> This webrev fixes a problem when apic_set_cpu() function is called for
>>> FIXED interrupt bypassing MSI checks
>>> in apic_grp_set_cpu(). CPU changing has sense for MIS/MSI-X interrupts
>>> only, so we should not allow it for
>>> FIXED interrupts. The patch checks at first if we're working with MSI
>>> interrupts. If it's not, exit from function
>>> setting *result to ENXIO.
>>>
>>> http://cr.illumos.org/view/2jmd24zk/illumos-725-webrev/
>>>
>>>
>>> --
>>> W.B.R.
>>> Dan Kruchinin
>>>
>>> _______________________________________________
>>> Developer mailing list
>>> Developer at lists.illumos.org
>>> http://lists.illumos.org/m/listinfo/developer
>>
>> _______________________________________________
>> Developer mailing list
>> Developer at lists.illumos.org
>> http://lists.illumos.org/m/listinfo/developer
>>
>



-- 
W.B.R.
Dan Kruchinin



More information about the Developer mailing list