[illumos-Developer] HAL with RBAC

[Garrett D'Amore]

On Mon, 2011-06-20 at 12:08 -0400, Albert Lee wrote:
> On Mon, Jun 20, 2011 at 11:39 AM, Andrew Stormont
> <andrew.stormont at nexenta.com> wrote:
> > Hi,
> >> Also, you need to use Nexenta copyrights on this stuff.  One of the side
> >> effects of working for a company is that your work on stuff associated with
> >> your employer
> >> becomes the property of your employer.
> > Yeah I was a little unsure about that as this was a weekend project of mine.
> >> You did not check the return value from g_strdup for NULL
> > The old code didn't check for NULL either but I see your point.  I will fix
> > this.
> >> Is the Hal upstream dead?
> > HAL is currently in maintenance state which means they're only accepting bug
> > fixes.  They do have a solaris backend though which is very broken so maybe
> > they'd still accept fixes to that.  I'm not sure if it makes a lot of
> > difference to us either way.
> >> Because one effect of these changes that I can see is that it would be
> >> harder to merge from the upstream.
> > I wouldn't worry about this making it harder to merge from upstream because
> > the PolicyKit code we already have in place is completely incompatible with
> > what upstream has.  Essentially what I've just done is replaced one
> > incompatible thing with another that has one less dependency, and HAL is the
> > only user of our current PolicyKit implementation.
> > Thanks,
> > Andy
> 
> HAL may be the only dependent in ON, but GDM and ConsoleKit also
> depend on PolicyKit. I assume this change doesn't affect them, though.

It shouldn't.  In fact, StormOS, IIUC, depends on "real" PolicyKit
rather than the libpolkit shim that we have had earlier.

	- Garrett

> 
> -Albert