[illumos-Developer] webrev for 1073: migrate kernel modules from ancient _depends_on to true ELF dependencies

[Garrett D'Amore]

On Mon, 2011-06-27 at 16:37 +0100, Bayard Bell wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Seinfeld taught me that someone who shows up for unpaid work can nevertheless be fired, so I'll be careful about impersonating a Nexenta employee, lest I be mailed a P45 and cease-and-desist order. I had mistakenly inferred that "warm-up" work should have Nexenta copyright, but I can also understand why, if I'm not a standard Nexenta employee but a less glorified form of project contractor, I should use my own name outside of project-specific changes.
> 
> Of course, I can understand from the latter that I should use my own name, but I'm still not entirely clear on where and how to do so. Should I be inserting my copyright line after the CDDL block, with any "use subject to terms" line following the Sun/Oracle copyright line and preceding mine?
> 
> Shall I take it from this lively exchange about copyright that the rest of my changes are otherwise passing review and that is all I need to worry about? Or is the relative prevalence of copyrights and removal of SCCS keywords just stealing the show? ;->

I didn't look at the whole set, but what I saw looked good.

For copyrights, just create your own block, don't touch the Sun/Oracle
ones, I think.

	- Garrett

> 
> Cheers,
> Bayard
> 
> On 27 Jun 2011, at 16:20, Garrett D'Amore wrote:
> 
> > You should be adding your own copyright, not Nexenta's.  You're not
> > doing this work as a Nexenta employee. :-)  (Are you looking for a job
> > at Nexenta. :-)
> > 
> > 	- Garrett
> > 
> > On Mon, 2011-06-27 at 15:21 +0100, Bayard Bell wrote:
> >> Ack'ed. I put the notices in because Cadmium told me to do it, but
> >> there's no further information that I could find saying how they
> >> should be done, only that they should be there for the current
> >> year. Whatever the answer is, it would be nice if it were posted
> >> somewhere like:
> >> 
> >> 
> >> https://www.illumos.org/projects/illumos-gate/wiki/How_To_Contribute
> >> 
> >> 
> >> On 27 Jun 2011, at 15:06, Richard Lowe wrote:
> >> 
> >>> The "use is subject to license terms" is part of the Sun copyright
> >>> notice.  You can't split those two lines up.
> >>> 
> >>> 
> >>> I don't know which copyright you should be adding, that's someone
> >>> elses problem.
> >>> 
> >>> -- Rich
> >>> 
> >>> 
> >> 
> >> _______________________________________________
> >> Developer mailing list
> >> Developer at lists.illumos.org
> >> http://lists.illumos.org/m/listinfo/developer
> > 
> > 
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.12 (Darwin)
> 
> iQIcBAEBAgAGBQJOCKPEAAoJEHm5cBpJ87doakEQAKNrX+yw/3k5NqbNfT4B3UlU
> w3WSBMOrlqFjHN+0PkwZlWLJuyujKBVt6I+p+GNRiXlXpsto15QN7tEOJ1QLjD54
> MHW2lrTQEhHjKxTxCRwNNAmR7sYUxq5Ej8oTnee05CvNzjSiV3wOvEP6w7V3LDsX
> 8vBqdsUGHmypM3r9IvbcX2iOei/4me1FSwjlz6WbDJOE3Ul5EgbzSlxAQTg7Uok9
> rMGtrBcdZBvVvY43xfrJIq65y+Au7p0IwaJuMDLPQTO+ggqn5BNaFe+d8ENw+NjZ
> YOub5ahju27Zoq682d7BCPAmbuPUbNYLFG7ek/d9RCI7d/ddrIH45VJzLFyJaK6K
> RRIkyG8XLj15nA15rnxXm7SRfiQsrQboVJXglkPuutUzZ3xHDHBmP02ZBMUNbGyn
> WLzSSNlZX8wjfbdDH+3SqFnWSAdNkuohSdPpqyRrOdP31jDV+05zmC0INvaydgbN
> DWxLGXGoya3VthHPDVjkhqABh420anwVG177LUvjoQ3ZGYg6wDvDKd8RBP7OB07D
> 6UbmCGN864Fg+C8aDWLoYCFIloAo5c8yP5ki7khClMxnT16uc+loFcMAEbD3x9E/
> UA1CtQ9LYgiKuP2AK68HES6Yxp2fWu/TjY0f1z5xXz9Gn7kJGsxXlXJMWKOuR9F/
> 4nz7GP0Jd2TDhDYfipnu
> =hooN
> -----END PGP SIGNATURE-----
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer