[illumos-Developer] webrev for 1073: migrate kernel modules from ancient _depends_on to true ELF dependencies

[Bayard Bell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

There are definitely strings from emlxs_fca_modopen in the driver, and these are also #ifdef MODSYM_SUPPORT. Poking a little further, this is down to usr/src/uts/common/sys/fibre-channel/fca/emlxs/emlxs_os.h: S11 is defined in usr/src/uts/(intel|sparc)/emlxs/Makefle, which sets SFCT_SUPPPORT in the header, which in turn sets MODSYS_SUPPORT. I'll make changes accordingly and fix the white-spacing as per the below.

On 27 Jun 2011, at 17:11, Richard Lowe wrote:

> Copyright stuff everyone else touched on.
> 
> emlxs:  What happened to this dependency?  Was MODSYM_SUPPORT not actually defined when we build it?
> 
> i86pc/rootnex: Does this correctly end up only having those dependencies when not built for Xen?  (I'm guessing so, since it's not in i86xpv/.../Makefile
> 
> nits:
> pcmci: Tab in the comment became a run of 8 spaces
> sd:  The tab after the two #defines became a run of spaces, should stay as a tab.
> 
> Otherwise looks great.
> 
> -- Rich
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.12 (Darwin)

iQIcBAEBAgAGBQJOCLj7AAoJEHm5cBpJ87doIoEQAIPocSVoacih7iKPYDQuT/pJ
kTrqxFHame0f7mTNQhbncbStZx0J5+uY5QSld2wJHeeYbUPj6V7x7dQrBkKhlnf5
PgxAj3oEv5EwEdF18n6ziHefrQmlETltmpn8kek7wYdPz4JccV60gaULA1sImT4f
ij43rkVY85UGmzXjjXz/SoSCtdOVrRaIVVpOdvwP7aYBDu9RXtf1LBYQ3CMaUPry
z+CJVUQ1WAFdsGKnJhiVANQmGzz2aXDWN6WtI5ZVFgUu1z5N5DCna5x4vCrBIshy
6xStCkBoimkFX5HiYyjFamj38e9mbkC60UdsR8GAtHe/XO8Uc7rXG2u/GkzcFODt
PX6zB72+/LQFJa9djB5n941RDxNJ6peFcSMJJRIOS5KvolkjA4DK8UUAcVpw+Nkf
mFkgizO3FMiNoMMb49SRIYwfZaWZUiDnOx3AIS6fTAcNHRfQX33OT26sSjpTMb0K
3q+6cRa8uFf3oT+AEAI7GNNGiAFdLk7RAroY6PJkmpgETuq7HhF0NGbLeHlNcncH
PHlKYWjJC6x/tUMwxldWKMQBeKA+F+Mr2KOeku4W1d1A17YHsXXUHdRbGVC7LNvB
WspsbWDFapADzGAZbiKLO2xvULl+n9p0OPQ5OR+g+vYUUBxHNEJQ4mTwLRMsp9Re
uRIvjk3PonMyP8rQPuVd
=y2Cx
-----END PGP SIGNATURE-----