[illumos-Developer] 1073-r1

[Adam Leventhal]

Hey Bayard,

Thanks a lot for reordering this -- it makes it so much easier to understand.

usr/src/uts/i86pc/cpr/Makefile
       58 +#       bootdev is marginal because the only explicitly identified
       59 +#       dependency is for SPARC-specific code.
I'm confused by that comment. Can you elaborate?

usr/src/uts/common/io/ppp/spppasyn/spppasyn_mod.c
I'm confused by the copyright updates
you can delete the filename from line 2 (and in every file -- there's
no need to record the filename in any file)

usr/src/uts/common/io/scsi/targets/sd.c
was __fibre ever defined? do we compile this file more than once?
please consolidate all the copyrights?

I don't see the corresponding Makefile changes for these files:
usr/src/uts/sun4u/montecarlo/io/pcf8591_nct.c
usr/src/uts/sun4u/montecarlo/io/pcf8574_nct.c
usr/src/uts/common/fs/nfs/nfs_server.c
usr/src/uts/common/inet/nca/ncaddi.c

but I'm sure I missed them -- can you point them out for me? It was a
big review ;-)

Adam

On Tue, Jun 28, 2011 at 10:31 AM, Bayard Bell
<buffer.g.overflow at googlemail.com> wrote:
> Please note the changed URL:
> http://dev1.illumos.org/~buffyg/illumos-1073-webrev-r1/
> Changes:
> as per ahl's suggestion, webrev re-ordered so that each changed source file
> is followed immediately by the related Makefiles or has a comment confirming
> that relevant Makefile(s) already correct (pcf_85*, nca, nfssrv)
> fixes for usr/src/uts/intel/md_mirror/Makefile,
> usr/src/i86pc/acpippm/Makefile caught in re-ordering exercise and fixed
> white-space change nits for usr/src/pcmcia.c and sd.c from richlowe
> emlxs dependency list now includes misc/fctl and explanatory comment, as
> follow-up to question from richlowe
> copyright lines modified so that they follow CDDL blocks where applicable
> and aren't interspersed with existing copyright/licensing
> language (confirmed that the Nexenta copyright notices that were already in
> sd.c and rootnex.c weren't mistakenly removed in making other copyright
> fixes)
> licensing terms copied with edits for generic application (contributor vs.
> Sun) for BSD-licensed source (spppasyn.c and spppcomp.c)
> where there is no change to the resulting binary, copyright removed
> (pcmcia.c)
> I've got a successful full build done with the code changes and an
> incremental against comment-only changes pending, and I have to ask richlowe
> or someone else with access to a SPARC build system to provide an
> incremental build with the emlxs Makefile change referenced above.
> I fixed issues that I found by re-ordering the webrev index as I went along.
> Some itinerant soul might want to have a look at:
> http://dev1.illumos.org/~buffyg/illumos-1073-webrev-r1/index_orig.html
> I'm also attaching the grep output I worked off to make it easier to
> cross-reference the Makefile changes:
>
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer
>
>



-- 
Adam Leventhal, Delphix
http://dtrace.org/blogs/ahl

275 Middlefield Road, Suite 50
Menlo Park, CA 94025
http://www.delphix.com