[illumos-Developer] 1073-r1

[Richard Lowe]

> usr/src/uts/common/io/scsi/targets/sd.c
> was __fibre ever defined? do we compile this file more than once?
> please consolidate all the copyrights?

sd.c is built twice, once to build 'sd' once to build 'ssd'.  Don't
look too hard too soon after eating.

> I don't see the corresponding Makefile changes for these files:
> usr/src/uts/sun4u/montecarlo/io/pcf8591_nct.c
> usr/src/uts/sun4u/montecarlo/io/pcf8574_nct.c
> usr/src/uts/common/fs/nfs/nfs_server.c
> usr/src/uts/common/inet/nca/ncaddi.c
>
> but I'm sure I missed them -- can you point them out for me? It was a
> big review ;-)

I haven't explicitly checked them all, but I think in my review I
noticed that nfs_server, at least, already had the Makefile entries,
but the _depends_on stuff had been left behind in addition.  (I know I
saw several cases of this, but I didn't think to write down for which
modules that was the case).

Bayard, if this is what happened can you let us know?

-- Rich