[illumos-Developer] [REVIEW] 1120 Use real file descriptors for smbfs named pipes.

Albert Lee trisk at opensolaris.org
Thu Jun 30 11:29:38 PDT 2011


Gave it a first pass, this is thing massive. The number of nested
member access macros under struct smb_ctx needed to follow something
like a sizeof() is disturbing.

No obvious problems... smb_share_{typename/parsetype} could use a
single table, I guess.

-Albert

On Wed, Jun 29, 2011 at 11:19 AM, Gordon Ross <gordon.w.ross at gmail.com> wrote:
> Anyone else want to review this? Or shall I just RTI it with one reviewer?
> (Thanks, Eric:)
>
>> Webrev updated, same place:
>> http://www.yalms.org/cr/illumos-1120/
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer
>



More information about the Developer mailing list