[illumos-Developer] code review request: 764 panic in zfs:dbuf_sync_list

Albert Lee trisk at opensolaris.org
Mon Mar 7 06:28:04 PST 2011


On Mon, Mar 7, 2011 at 1:18 AM, Gordon Ross <gordon.w.ross at gmail.com> wrote:
> This fixes: 764 panic in zfs:dbuf_sync_list
> http://cr.illumos.org/view/ro1lhqm2/
>
> This has been reviewed by some ZFS folks already.
> Wanted to let the rest of you see it before I submit
> the request to integrate.
>
> This is pretty urgent, so please respond within
> a day or so if you want this tweaked.
>

In the Nexenta review, I mentioned that we could avoid taking
dn->dn_mtx in the spill block has-holds case, although Gordon
correctly pointed out that this is a very low-frequency condition. I
also suggested clarifying the second comment to mention that our list
removals from dn_dirty_records apply to two different insert paths in
dbuf_dirty().

Doesn't seem important, though.

-Albert



More information about the Developer mailing list