[illumos-Developer] code review request: 764 panic in zfs:dbuf_sync_list

[Gordon Ross]

On Mon, Mar 7, 2011 at 9:28 AM, Albert Lee <trisk at opensolaris.org> wrote:
> On Mon, Mar 7, 2011 at 1:18 AM, Gordon Ross <gordon.w.ross at gmail.com> wrote:
>> This fixes: 764 panic in zfs:dbuf_sync_list
>> http://cr.illumos.org/view/ro1lhqm2/
[...]

> In the Nexenta review, I mentioned that we could avoid taking
> dn->dn_mtx in the spill block has-holds case, although Gordon
> correctly pointed out that this is a very low-frequency condition. I
> also suggested clarifying the second comment to mention that our list
> removals from dn_dirty_records apply to two different insert paths in
> dbuf_dirty().
>
> Doesn't seem important, though.
>
> -Albert

I liked the feedback.  Just didn't have time to handle it previously.
Here's an updated webrev based on your feedback:

http://cr.illumos.org/view/r2vw01lm/

Thanks,
Gordon